Skip to content

feat(cli): generate commands for conditional tools#1962

Merged
nroscino merged 10 commits intomainfrom
feat/update-cli
Apr 30, 2026
Merged

feat(cli): generate commands for conditional tools#1962
nroscino merged 10 commits intomainfrom
feat/update-cli

Conversation

@nroscino
Copy link
Copy Markdown
Contributor

@nroscino nroscino commented Apr 27, 2026 •
edited
Loading

This PR adds all tools in the CLI interface. When a tool is not enabled the server responds with an error guiding the user on how to enable the category or the experiment.

Closes: #1933

@nroscino nroscino requested a review from OrKoN April 27, 2026 15:18
@nroscino nroscino marked this pull request as ready for review April 27, 2026 15:18
OrKoN
OrKoN reviewed Apr 27, 2026
View reviewed changes
Comment thread skills/chrome-devtools-cli/SKILL.md Outdated
OrKoN
OrKoN reviewed Apr 27, 2026
View reviewed changes
Comment thread skills/chrome-devtools-cli/SKILL.md Outdated
OrKoN
OrKoN reviewed Apr 27, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools-cli-options.ts
OrKoN
OrKoN reviewed Apr 27, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools-cli-options.ts Outdated
OrKoN
OrKoN reviewed Apr 27, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools-cli-options.ts Outdated
@nroscino nroscino self-assigned this Apr 28, 2026
OrKoN
OrKoN reviewed Apr 28, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools-cli-options.ts
@nroscino nroscino requested a review from OrKoN April 28, 2026 14:10
OrKoN
OrKoN reviewed Apr 28, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools-cli-options.ts Outdated
@nroscino nroscino requested a review from OrKoN April 28, 2026 15:28
@OrKoN
Copy link
Copy Markdown
Collaborator

OrKoN commented Apr 28, 2026

The tests seem to fail still.

OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools.ts
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools.ts
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools.ts
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread src/bin/chrome-devtools.ts
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread src/index.ts Outdated
@nroscino nroscino requested a review from OrKoN April 29, 2026 10:44
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread scripts/generate-cli.ts
OrKoN
OrKoN reviewed Apr 29, 2026
View reviewed changes
Comment thread scripts/generate-cli.ts
nroscino
nroscino commented Apr 29, 2026
View reviewed changes
Comment thread src/telemetry/flag_usage_metrics.json
@nroscino nroscino requested a review from OrKoN April 29, 2026 15:29
@OrKoN OrKoN changed the title chore: update CLI generator to generate all possible tools feat: update CLI generator to generate all possible tools Apr 30, 2026
@OrKoN OrKoN changed the title feat: update CLI generator to generate all possible tools feat(CLI): generate commands for conditional tools Apr 30, 2026
OrKoN
OrKoN approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@OrKoN
Copy link
Copy Markdown
Collaborator

OrKoN commented Apr 30, 2026

Looks like this PR needs a rebase

@OrKoN OrKoN mentioned this pull request Apr 30, 2026
Open
@OrKoN OrKoN changed the title feat(CLI): generate commands for conditional tools feat(cli): generate commands for conditional tools Apr 30, 2026
@OrKoN
Copy link
Copy Markdown
Collaborator

OrKoN commented Apr 30, 2026

@nroscino please link the issue it is closing

@nroscino nroscino added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit b2b3e99 Apr 30, 2026
20 checks passed
@nroscino nroscino deleted the feat/update-cli branch April 30, 2026 08:08
@browser-automation-bot browser-automation-bot mentioned this pull request Apr 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees

@nroscino nroscino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update CLI generator to generate interfaces for all possible tools

2 participants

@nroscino @OrKoN